Leave Of Absence v0.9

phpVMS Legacy Add-Ons (v2/v5) Releases
81

Everything works flawless and looks good except, when I applied for LoA as a test pilot, I logged out, cleared cookies and cache and then logged back in as admin. I went in and viewed said pilots request and hit delete. After delete, it said are you sure. i clicked delete and nothing happens it just stays on the very same page. goes nowhere and pilot is not deleted from the database. If I click no, that I do not want to delete the request, it also stays on that page and does nothing. that’s as far as it will go. I did test all errors that were testable and all worked such as already exists, date is to long etc etc.

I am going to go back now and try to approve a pilots leave of absence. I will come report back if approval is successful.

On a side note, all database connection errors are gone as well as deprecated code errors.

82

Oh ok. I see no approval is needed for leave of absence.

You are viewing the Leave of Absence Request for pilot The pilot’s leave started on the following date: 12/09/2016

The pilot’s leave will end on the following date: 12/31/2016

The pilot has specified the following reason for submitting the LoA request:

I left the reason off for a very good reason. it might have had a swear word in it. lol

83

If you can, shoot me your FTP details (along with a test pilot account) to PM and I’ll take a look.

Glad it works

84

Coming at ya right now bud. Give me say 5 minutes. Got to run my dog out for a quick moment

85

Spot on! Very nice. Ty very much for another great addition to phpVMS! I added you to my credits page with your brand image.

86

Thanks. To all,

I’ve updated the module. As Ray has told me, it should work correctly.

Download https://github.com/savamarkovic/phpvms_loa

Regards

Sava

1 Like
87

All though i have no pilots as my site is brand new, I have tested it over and over with my johnny tester account and so far it has worked flawless.

1 Like
88

hey real quick while I have this file open and before I forget what I was going to ask, in this piece of code :

private static $maxDuration = 61;

 

I change the 61 to what ever number I wish such as 90 for 90 days correct?

89

I found a very minor error in the module in the admin panel.

When a pilot sends in a request and you click view, it is supposed to display the pilots name and profile link and it does not. Also on confirm deletion of LoA request, it does not display the pilot id neither.

However, it does display the pilots name and pilot id number properly on LoA Admin Index page

Quote

You are viewing the Leave of Absence Request for pilot  (missing PID and link)
The pilot’s leave started on the following date: 12/17/2016
The pilot’s leave will end on the following date: 01/30/2017
The pilot has specified the following reason for submitting the LoA request:

Hi Ray testing email

Quote

Delete A Leave of Absence Request

Are you sure you want to delete a LoA Request for pilot (Missing PID and Link)

 

90

4 hours ago, TAV1702 said:

hey real quick while I have this file open and before I forget what I was going to ask, in this piece of code :

private static $maxDuration = 61;

 

I change the 61 to what ever number I wish such as 90 for 90 days correct?

I may have a slightly newer version than you Ray. At the end of that line, mine states: // Edit this value to set the max LOA Duration

I think (as in I’m not positive) you would set it to the number of days - plus 1 day. So if you limit an LOA to 90 days, it will expire on day 91. This provides the pilot a full 90 days of LOA.

91

We probably have the same version if you got the new one. I was on skype with Sava when he released this and I grabbed it. I do have that comment as well in mine I just failed to post it. sorry about that. I was just sure about the 1 extra day thing on there.

I appreciate the reply Pro. Thanks man. I’ll go fix that right quick before I forget.

92

Hey guys, without looking at the code, I think I entered to account for the difference in time.
A huge part of the module is still legacy code from when I was still learning. I’ll get the update done soon. (And send it for you to review Ray :P)

93

I don;t know if it is a problem on my end but sava’s loa repo is not opening. I am getting these errors on client side:

Deprecated: Non-static method LoAData::CheckPilotID() should not be called statically, assuming $this from incompatible context in /storage/ssd3/285/3946285/public\_html/core/modules/LoA/LoA.php on line 66 Deprecated: Non-static method LoAData::AddLoa() should not be called statically, assuming $this from incompatible context in /storage/ssd3/285/3946285/public\_html/core/modules/LoA/LoA.php on line 76

And these on the admin side:

Deprecated: Non-static method LoAData::GetAllRequests() should not be called statically, assuming $this from incompatible context in /storage/ssd3/285/3946285/public\_html/admin/modules/LoA/LoA.php on line 35 Warning: fgetcsv() expects parameter 1 to be resource, boolean given in /storage/ssd3/285/3946285/public\_html/admin/modules/LoA/LoA.php on line 83 Warning: fclose() expects parameter 1 to be resource, boolean given in /storage/ssd3/285/3946285/public\_html/admin/modules/LoA/LoA.php on line 84

 

94

open core/common/LOaData.class

change all the

public function

to

public static function

 

95

On 22/7/2013 at 11:51 AM, OA01 said:

I found the solution myself.

Open //core/common/LoAData.class and locate the following:

 

public function GetAllRequests ()
{
$table = TABLE_PREFIX;
$sql = “SELECT loa.pilotid,
loa.start,
loa.end,
loa.reason,
phpvms_pilots.pilotid,
phpvms_pilots.firstname,
phpvms_pilots.lastname
FROM loa
JOIN phpvms_pilots ON loa.pilotid = phpvms_pilots.pilotid”;
$ret = DB::get_results($sql);
return $ret;

 

 

And replace it with this:

 

public function GetAllRequests ()
{
$table = “.TABLE_PREFIX.”;
$sql = “SELECT loa.pilotid,
loa.start,
loa.end,
loa.reason,
pilots.pilotid,
pilots.firstname,
pilots.lastname
FROM loa
JOIN pilots ON loa.pilotid = pilots.pilotid”;
$ret = DB::get_results($sql);
return $ret;

Good afternoon. I tried to edit the file but it does not work. No data in the DB and in the admin panel (no error is shown) How to solve? thank you

 

Now the admin function works OK.

 

96

Good Morning Lades & Gents,

I would really like to use this module as im running Classic VMS 5.5 (PHP version) but sadly none of the download links work  could anyone provide me with a download link?

Looks like a fantastic addition to my site.

Kind Regards Harry.

97

6 hours ago, harryh146 said:

Good Morning Lades & Gents,

I would really like to use this module as im running Classic VMS 5.5 (PHP version) but sadly none of the download links work  could anyone provide me with a download link?

Looks like a fantastic addition to my site.

Kind Regards Harry.

I packaged mine for you. You will need to change the classes to match your css.

 

Download Here!

98

On 7/1/2018 at 5:34 PM, flyalaska said:

I packaged mine for you. You will need to change the classes to match your css.

Hi FlyAlaska thank you very much for uploading that for me ! No worries re-doing my css sheet at the moment anyway, Thanks again ! Kind Regards Harry

99

1 hour ago, harryh146 said:

Hi FlyAlaska thank you very much for uploading that for me ! No worries re-doing my css sheet at the moment anyway, Thanks again ! Kind Regards Harry

The loa.sql file is missing, which you can download from here: https://github.com/carriercomm/phpvms_loa

Use the loa.sql file to create the table necessary for the module to work. You can do this by using phpmyadmin.

100

53 minutes ago, gio1961 said:

The loa.sql file is missing, which you can download from here: https://github.com/carriercomm/phpvms_loa

Use the loa.sql file to create the table necessary for the module to work. You can do this by using phpmyadmin.

Forgot about that.