Everytime a pilot of mine files a pirep and i accept it, it is doubled in the roster, one guy flew once, had 6.3 on the roster then flew again and got 10.5, it came out as 27.3 is there anything i can do to fix this? If so which file do I have to edit to fix it?
Cheers
Dan C
I do have the same issue… Nabeel, could you tell me where the flight hours are being calculated so I can check the calculation process ?
Cheers !
I’m looking into this, but core/classes/util.class.php, line 50 the AddTime() function, though I have a feeling it’s somewhere else time being double-added, where I’m missing. Some of the code is unweildy and begs a refactoring
Just tell me if you need to double check some stuff…
Will do; it’s odd because my unit testing seems to indicates that it works, so I’m trying to debug in some detail.
Wait - are you guys using the beta copy?
I am using version 1.2.628 doesn’t say beta, i downloaded it from the downloads section of this site, so i don’t think it is the beta copy.
Cheers
Dan C
Ok, the hours problem is fixed in the beta, it’s in downloads.phpvms.net
Forgive me my ignorance … can someone tell me how do I get that file update beta
(downloads.phpvms.net) is this the download website phpvms Update Install???
Thanks guys.
No problem, it’s the phpvms.beta.zip
Can we use beta in production or there are other ustable stuff ?
I don’t want to have other surprises !
Cheers
I try to keep each beta build in working condition, except for new features which may not be always complete
Nabeel, please check your last PM as I posted you a modification for Utils.class
As I am no coder, I need your check but I think it works !
Cheers
It seems as though that did the trick, I’ve posted it into the beta and committed it, thanks!!
Helps having fresh eyes look at it
Dear Nabeel
We updated our Version to 1.2.637 but we still got the problem that the system “doubles” the hours for some reason. Is there any new Version or bugfix? Please help
Thank you!
Nagelfar
I haven’t had the chance to figure that bug out yet, but it’s on my list.
There’s a ticket in the bug tracker, if you subscribe to it, you’ll know once it’s fixed
Do you have details? Which kind of PIREPs, meaning FSACARs or manual, etc
Ok, I have noticed that when a pilot files a flight the system adds 1 to their flights, then when I accept the PIREP the system adds the same flight again…Its being added 2 times.
its also doubling the pilot pay…
Alright, give it a try (beta build)
Sending admin/modules/PIREPAdmin/PIREPAdmin.php
Sending core/common/PIREPData.class.php
Transmitting file data ..
Committed revision 638.
it only happens with fsacars pireps - the manual one are ok
Ok, I just did a flight, the system is not doing the addition correctly, flight hours are wrong and pilot pay was off again…It did only add 1 flight like it was supposed to, so that is fixed.