Rev 931 - VMS-283 VMS-284 VMS-285 VMS-286 VMS-287 VMS-288 #closed fixed

[Nabeel]

Updated Tickets:

[VMS-283] - TOTAL_HOURS missing in install/update

[VMS-284] - Pilot pay not calculated correctly

[VMS-285] - Use 7 for Sunday in addition to 0

[VMS-286] - Edit Expenses shows error

[VMS-287] - Cache issues with airlines

[VMS-288] - Add 'asp_tags' check to checkinstall script

Changed Files:

m admin/templates/finance_expenselist.tpl

m core/common/OperationsData.class.php

m core/common/PIREPData.class.php

m core/templates/schedule_results.tpl

m core/version

m install/checkinstall.php

m install/hashlist

m install/install.sql

m install/structure.xml

m install/update.sql

VMS-283 VMS-284 VMS-285 VMS-286 VMS-287 VMS-288 #closed fixed

View complete changes

Download from here

[simpilot]

I have not been able to see the airport listing on the admin side all the time and I think I came up with the issue. I usually use ie8 and that is when I was having no airports display.

Line 43 ops_airportlist.tpl

error in IDE - Trailing comma not supported in all browsers

ajax:'<?php echo adminaction('/operations/editairport?icao=');?>'+icao,

If i remove the comma after icao all the airports show up both in ie8 and ff.

checkinstall.php looks good on 931

Checking PHP version
[OK] PHP version is 5.2.x

ASP Tags
[OK] ASP-style tags are disabled

Checking connectivity...
[OK] Can contact outside servers

Checking for SimpleXML module...
[OK] SimpleXML module exists!

Checking file hashes for corrupt or mismatched files
[OK] No errors found!

-- Checked 183 files, found 0 errors

[Nabeel]

Thanks Dave, I hate IE. I think I have a few of those lurking around somewhere, gotta search em out.

Added the ASP tags check, seems like that's been coming up now since the JS templates use the <% %> tags

[lorlandi]

Hi, a little detail in edit expenses, the frame appear but in blank, see attached image.

Regards

[Guest lorathon]

I am still not getting the schedules to show up in the admin page. I have cleared the cache and still no joy.

[Nabeel]

I am still not getting the schedules to show up in the admin page. I have cleared the cache and still no joy.

Strange, schedules aren't cached. Anything in the debug log? How about the /checkinstall.php and /checkdb?

Also, those are loaded by AJAX, so anything in the error console? Or IE throwing any javascript errors?

[Guest lorathon]

Strange, schedules aren't cached. Anything in the debug log? How about the /checkinstall.php and /checkdb?

Also, those are loaded by AJAX, so anything in the error console? Or IE throwing any javascript errors?

Checkinstall.php - The Download error is due to me removing the auth check I am sure

phpVMS Virtual Airline Administration Software

Install Check

Checking PHP version

[OK] PHP version is 5.2.x

ASP Tags

[OK] ASP-style tags are disabled

Checking connectivity...

[OK] Can contact outside servers

Checking for SimpleXML module...

[OK] SimpleXML module exists!

Checking file hashes for corrupt or mismatched files

[Checksum failed] /core/modules/Downloads/Downloads.php did not match, possibly corrupt or out of date

-- Checked 183 files, found 1 errors

Checkdb.php

phpVMS Virtual Airline Administration Software

Database Check

Checking phpvms_acarsdata...OK

Checking phpvms_adminlog...OK

Checking phpvms_aircraft...OK

Checking phpvms_airlines...OK

Checking phpvms_airports...OK

Checking phpvms_awards...OK

Checking phpvms_awardsgranted...OK

Checking phpvms_bids...OK

Checking phpvms_customfields...OK

Checking phpvms_downloads...OK

Checking phpvms_expenselog...OK

Checking phpvms_expenses...OK

Checking phpvms_fieldvalues...OK

Checking phpvms_financedata...OK

Checking phpvms_fuelprices...OK

Checking phpvms_groupmembers...OK

Checking phpvms_groups...OK

Checking phpvms_navdata...OK

Checking phpvms_news...OK

Checking phpvms_pages...OK

Checking phpvms_pilots...OK

Checking phpvms_pirepcomments...OK

Checking phpvms_pirepfields...OK

Checking phpvms_pireps...OK

Checking phpvms_pirepvalues...OK

Checking phpvms_ranks...OK

Checking phpvms_schedules...OK

Checking phpvms_sessions...OK

Checking phpvms_settings...OK

Checking phpvms_updates...OK

Chrome Javascript Console

XHR finished loading: "http://fs-products.net/PhoenixVA/admin/action.php/operations/schedulegrid?_search=false&nd=1272311197967&rows=25&page=1&sidx=flightnum&sord=asc".

schedules:1Uncaught SyntaxError: Unexpected token <

[Nabeel]

Chrome Javascript Console

XHR finished loading: "http://fs-products.net/PhoenixVA/admin/action.php/operations/schedulegrid?_search=false&nd=1272311197967&rows=25&page=1&sidx=flightnum&sord=asc".
schedules:1Uncaught SyntaxError: Unexpected token <

Hmm... what if you try in IE or FF? Any problems? I'm loading up Chrome now

[Nabeel]

Hmm no problems with Chrome here. Try IE and FF, see if there's any errors there.

Try this - open admin/modules/operations/operations.php. Line 500 is:

header("Content-type: text/x-json");

In the schedulegrid() function - try commenting out that line, does it help? What about changing it from x-json to just json?

And this URL:

http://fs-products.net/PhoenixVA/admin/action.php/operations/schedulegrid?_search=false&nd=1272311197967&rows=25&page=1&sidx=flightnum&sord=asc

If you click that, what does it output?

[Guest lorathon]

for the link

Fatal error: Allowed memory size of 67108864 bytes exhausted (tried to allocate 77 bytes) in /home/fsprodu1/public_html/PhoenixVA/core/classes/ezdb/ezdb_mysql.class.php on line 273

I see this when I try and pull all of the schedules at once. All of my schedules pulls have been limited to 1000 schedules. This stops the memory errors. The admin schedule from the previous version must have done the same. It works with our 82000+ schedules.

Any way to limit the number of pulls? If need be I can maintain a separate module.

[Guest lorathon]

Hmm no problems with Chrome here. Try IE and FF, see if there's any errors there.

Try this - open admin/modules/operations/operations.php. Line 500 is:

header("Content-type: text/x-json");

In the schedulegrid() function - try commenting out that line, does it help? What about changing it from x-json to just json?

And this URL:

http://fs-products.net/PhoenixVA/admin/action.php/operations/schedulegrid?_search=false&nd=1272311197967&rows=25&page=1&sidx=flightnum&sord=asc

If you click that, what does it output?

I tried all of that and nothing changed.

[Guest lorathon]

So I started looking through the Operations file and noticed that there is a call without limits to find the count of all schedules.

$count = count(SchedulesData::findSchedules($where));

Well I know that pulling all schedules hits the memory error. But the stats data counts them just fine. So I commented out the above line and added the following.

$count = StatsData::TotalSchedules();

BINGO Working.

But it is only pulling the first 16,270 schedules

[Guest lorathon]

So I started looking through the Operations file and noticed that there is a call without limits to find the count of all schedules.

$count = count(SchedulesData::findSchedules($where));

Well I know that pulling all schedules hits the memory error. But the stats data counts them just fine. So I commented out the above line and added the following.

$count = StatsData::TotalSchedules();

BINGO Working.

But it is only pulling the first 16,270 schedules

OOOOOOPPPPSSS.

I forgot this was on the test site. It is showing all of the schedules.

[Nabeel]

Memory error??

Yeah, the count is for pagination. Hmm.