Jump to content
Sava

Leave Of Absence v0.9

Recommended Posts

You already have the response lol

We are the same VA, that's why he mentioned William in his previous post.

I thought it was inferred from my previous response as well, sorry. 

Edited by William

Share this post


Link to post
Share on other sites

Sorry, missed that connection...

 

What version of the LoA module? 

Where did you download it from?

Share this post


Link to post
Share on other sites

The version is 1.0, the last one available. It was throwing more errors as already described by many members in different posts and I

cleaned them all up.

The only thing which still does not work is the error thrown when we try to delete a LOA request. That error is connected to the function

in Line 63 that Sean had posted about. Basically, it's not talking to the DB and the function needs to be rewritten, but I didn't have time.

Share this post


Link to post
Share on other sites

It works on my site with phpVMS 5.5.2.72 under PHP 7.2 / MySQL 5.6 -- but my LoA.php file is a bit different. I'll look at it later today and let you know what I find.

Share this post


Link to post
Share on other sites

That's part of the problem. We cannot use php 7.2 as it breaks other things.

This VA is running on 20+ different add-on modules and I don't have to explain any

of you what a headache it is to make them all work together nicely. 😉

Edited by William

Share this post


Link to post
Share on other sites

While it's a headache, we have been able to get 15+ addons to work just fine under PHP 7.2 . What we found is that many have similar errors and are easily fixed.

Share this post


Link to post
Share on other sites

Yes, I'm sure you did, but with over 200 active pilots, I'm not about to go fiddle with things that can break the site and create bigger problems unless I have to, especially over something small like LOA requests that I can easily delete straight from the DB. Also we have add-on nobody else does so it's hard to compare.

Anyway, thanks for looking into it

Edited by William

Share this post


Link to post
Share on other sites

That is why you always install new as a development site. Never mess with a working live site until you work out all the bugs.

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Loading...

×
×
  • Create New...