Aircraft location CSV file

[Karajr1]

Hello, after i have uploaded my fleet in cvs file the aircraft has no location yet. But if I manual add an aircraft I can choose its location and this is going to take along time is there a work around?

 

Thanks Jerry

 

[ProAvia]

Have you looked at the aircraft table in the database? I believe there is an "airport_id" field. 

My guess is that you need to include that "airport_id" field in the aircraft CSV file and have an actual airport ID in it before you import the aircraft file.

[Nabeel]

I believe there's a github issue for this - the initial starting column is missing from the csv

[Karajr1]

Nabeel, do you have a link to this on github?

 

Thanks Jerry

[Nabeel]

It's in the header

[LesJar]

I just fixed this in a PR which is awaiting inclusion , along with other csv fixes I found that were needed 

 

[DisposableHero]

I saw those PR's and kindly informed you about the main requirements. I see you merged them in one PR, which is kind of mandatory but still failing a simple style check

 

 

When you click the Details link, it will show you the errors in red and possible solutions in green lines.

 

 

So here in this particular file, you have 2 non necessary spaces  First one is before the public, second one is after the comma. Deleting those spaces then saving the file will let the code to continue processing your changes.

 

Every PR needs to pass some checks, these may be simple styling checks or complete build tests. And every PR has to run/pass those tests on their own 'cause they are threated as separate applications. They may work on your local environment without proper styling but this is not the case for being approved as core changes.

 

Hopes this little info helps and you fix that simple style error, pass the tests and they get approved afterwards.

 

[LesJar]

Thank you for your time explaining the issue with STYLE ,  yes that is something important to consider when making changes to PHPVMS v7.